-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luci-base: add member allowduplicates
to DynamicList
#7558
Conversation
I've tried a few other solutions, but they are all too heavy. This is currently the simplest stupidst solution I can come up with. |
The change is small and seems reasonable. Maybe we can find other places were the duplicate property is needed? Just to have a better understanding. Because now I think that we can just remove the check for a duplicates, or show a confirmation to a user when adding a duplicate. @systemcrash The word "duplicate" is an action so maybe call it "duplicates" or even "allowDuplicates" or "duplication"? |
force pushed. |
duplicate
to DynamicList
allowduplicates
to DynamicList
Add member `allowduplicates` to `DynamicList` to allow duplicate underlying form values. `allowduplicates` defaults is `null`, `DynamicList` will keep the same behavior as before. If `true`, the underlying form value will not be checked for duplication. Signed-off-by: Anya Lin <[email protected]>
Signed-off-by: <[email protected]>
row (viagit commit --signoff
)<package name>: title
first line subject for packagesPKG_VERSION
in the MakefileDescription:
Add member
allowduplicates
toDynamicList
to allow duplicate underlying form values.allowduplicates
defaults isnull
,DynamicList
will keep the same behavior as before.If
o.allowduplicates = true
, the underlying form value will not be checked for duplication.Screenshot: